Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional small cleanups to as a followup to removing self._val #1402

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 30, 2024

followup to #1397

  • avoid elif blocks
  • made the __new__ code a bit more concise
  • avoid some unneeded intermediate variables
  • make URL object creation always happen in the same order

Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #1402 will not alter performance

Comparing new_pref_check (da3cc58) with master (71d171e)

Summary

✅ 82 untouched benchmarks

@bdraco bdraco changed the title Refactor URL.__new__ to avoid elif blocks Refactor URL.__new__ to avoid elif blocks Oct 30, 2024
@bdraco bdraco changed the title Refactor URL.__new__ to avoid elif blocks Small cleanups to URL.__new__ Oct 30, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 30, 2024
@bdraco bdraco changed the title Small cleanups to URL.__new__ Additional small cleanups to as a followup to removing self._val Oct 30, 2024
@bdraco bdraco changed the title Additional small cleanups to as a followup to removing self._val Additional small cleanups to as a followup to removing self._val Oct 30, 2024
@bdraco bdraco marked this pull request as ready for review October 30, 2024 19:24
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (71d171e) to head (da3cc58).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
- Coverage   99.61%   96.05%   -3.57%     
==========================================
  Files          23       31       +8     
  Lines        4716     5747    +1031     
  Branches      311      343      +32     
==========================================
+ Hits         4698     5520     +822     
- Misses         18      201     +183     
- Partials        0       26      +26     
Flag Coverage Δ
CI-GHA 96.05% <100.00%> (-3.51%) ⬇️
MyPy 48.79% <90.00%> (?)
OS-Linux 99.55% <100.00%> (-0.01%) ⬇️
OS-Windows 99.61% <100.00%> (-0.01%) ⬇️
OS-macOS 99.29% <100.00%> (-0.01%) ⬇️
Py-3.10.11 99.27% <100.00%> (-0.01%) ⬇️
Py-3.10.15 99.51% <100.00%> (-0.01%) ⬇️
Py-3.11.10 99.51% <100.00%> (-0.01%) ⬇️
Py-3.11.9 99.27% <100.00%> (-0.01%) ⬇️
Py-3.12.7 99.51% <100.00%> (+0.23%) ⬆️
Py-3.13.0 99.51% <100.00%> (-0.01%) ⬇️
Py-3.9.13 99.23% <100.00%> (-0.32%) ⬇️
Py-3.9.20 99.46% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 99.52% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.17 99.55% <100.00%> (-0.01%) ⬇️
VM-macos-latest 99.29% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 99.55% <100.00%> (-0.01%) ⬇️
VM-windows-latest 99.61% <100.00%> (-0.01%) ⬇️
pytest 99.55% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 979e06a into master Oct 30, 2024
44 of 46 checks passed
@bdraco bdraco deleted the new_pref_check branch October 30, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant