Skip to content

Conversation

@jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Apr 25, 2025

Description of Change

  • Set minimal permissions for CI/CD GitHub workflow

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Fix code scanning alert - Workflow does not contain permissions #1332
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Apr 25, 2025
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (b33747e) to head (e7b6af6).
Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1333   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files          67       67           
  Lines        6559     6559           
=======================================
  Hits         5958     5958           
  Misses        601      601           
Flag Coverage Δ
unittests 90.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller marked this pull request as ready for review April 25, 2025 08:12
@jakob-keller jakob-keller enabled auto-merge April 25, 2025 08:12
@jakob-keller jakob-keller self-assigned this Apr 25, 2025
@webknjaz
Copy link
Member

Might be a good idea to add a zizmor workflow..

@jakob-keller
Copy link
Collaborator Author

Might be a good idea to add a zizmor workflow..

Opened as #1334

@jakob-keller jakob-keller removed the request for review from thehesiod April 25, 2025 12:18
@jakob-keller jakob-keller marked this pull request as draft April 25, 2025 12:24
auto-merge was automatically disabled April 25, 2025 12:24

Pull request was converted to draft

@jakob-keller jakob-keller force-pushed the github-actions-permissions branch from d377dfd to e7b6af6 Compare April 25, 2025 12:25
@jakob-keller jakob-keller marked this pull request as ready for review April 25, 2025 12:28
@jakob-keller jakob-keller enabled auto-merge April 25, 2025 12:28
@jakob-keller jakob-keller requested a review from webknjaz April 25, 2025 12:29
@jakob-keller jakob-keller added this pull request to the merge queue Apr 25, 2025
@jakob-keller
Copy link
Collaborator Author

@webknjaz: Thanks a lot for you reviews and suggestions!

Merged via the queue into aio-libs:master with commit 6efb546 Apr 25, 2025
32 of 33 checks passed
@jakob-keller jakob-keller deleted the github-actions-permissions branch April 25, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Workflow does not contain permissions

2 participants