Fix markdown reader image path #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
moria97
reviewed
Jan 7, 2025
| @@ -55,9 +58,12 @@ def replace_image_paths(self, markdown_name: str, content: str): | |||
| for match in html_image_matches: | |||
| @@ -55,9 +58,12 @@ def replace_image_paths(self, markdown_name: str, content: str): | |||
| for match in html_image_matches: | |||
| full_match = match.group(0) # 整个匹配 | |||
| local_url = match.group(1) # 捕获的URL | |||
| image_name = os.path.basename(local_url) | |||
There was a problem hiding this comment.
image有可能会有上层目录，比如"figures/docs/1.jpg"
There was a problem hiding this comment.
建议这样写
def is_url(url):
"""判断是否为 URL"""
try:
result = urlparse(url)
return all([result.scheme, result.netloc])
except ValueError:
return False
base_dir = os.path.basedir(markdown_path)
if not is_url(image_path):
image_path = os.path.join(base_dir, image_path) #绝对路径不会被合并There was a problem hiding this comment.
image在上传的时候，上层目录没有被保留
moria97
reviewed
Jan 8, 2025
| else: | ||
| content = content.replace(f"", "") | ||
| content = content.replace(full_match, "") | ||
| for match in html_image_matches: |
There was a problem hiding this comment.
这段和上面165-178行看起来一模一样？可以写到一起吗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.