Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test script for examples #151

Closed
wants to merge 88 commits into from
Closed

test script for examples #151

wants to merge 88 commits into from

Conversation

johanos1
Copy link
Collaborator

@johanos1 johanos1 commented Feb 24, 2023

Description

Summary of changes

  • test script to be invoked that runs each of the examplesi, i.e., Jupyter notebooks and the MPI example.
  • renamed the visualization example to be coherent with the other examples.

Resolved Issues

How Has This Been Tested?

The script was run on my laptop. Verified by introducing errors in the examples and running the correct one.
The workflow will be tested automatically.

Related Pull Requests

@johanos1 johanos1 added enhancement New feature or request tests Anything related to the tests labels Feb 24, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes in workflow

on:
push:
branches:
- master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have no master branch, I think you mean main? :)

It should probably also run on PRs like this one?

(see here for example

)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I read up a bit and I updated the workflow that we have instead.

- name: Run the test examples
shell: bash -l {0}
run: |
pip install seaborn=0.12, mpi4py, pytorch, scikit-learn, rasterio, scikit-image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think probably you would want to set up a conda env so it works the same as our other tests (otherwise we end up maintaining two different types of workflows). miniconda install should also be more uptodate and stable I hope

See here

- name: provision-with-micromamba

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, using the same environment as the tests now.

@github-actions
Copy link

github-actions bot commented Mar 29, 2023

Overall Coverage

Coverage Report
FileStmtsMissCoverMissing
paseos
   __init__.py31294%46, 49
   paseos.py1471490%73–74, 153–156, 207, 224, 242, 251, 269, 300, 308–311, 411–412
paseos/activities
   activity_manager.py43393%46, 76, 159
   activity_processor.py58198%123
   activity_runner.py621084%80–84, 104–113, 122–125
paseos/actors
   actor_builder.py871286%18–24, 27, 125–134, 267, 330
   base_actor.py1021585%101, 141–143, 172, 181, 202, 227, 233–236, 240, 254, 304
   ground_station_actor.py15380%47–53
   spacecraft_actor.py61198%123
paseos/communication
   get_communication_window.py22291%38, 67
   is_in_line_of_sight.py741580%75, 82, 90, 152–169, 213, 233
paseos/power
   charge_model.py17194%54
   discharge_model.py7271%22, 34
   is_in_eclipse.py39490%28–29, 90–91
paseos/tests
   activity_test.py57395%92, 95–96
   communication_window_test.py58198%198
   eclipse_test.py11191%22
   import_test.py6183%13
   init_test.py8188%16
   line_of_sight_test.py65494%147–150
   thermal_model_test.py30197%63
   visualization_test.py20195%31
paseos/utils
   check_cfg.py611870%31, 40, 46, 62–64, 71, 74–76, 79–81, 84–86, 101, 106
   operations_monitor.py55198%84
paseos/visualization
   animation.py18667%27–30, 35, 44
   plot.py9367%28–31
   space_animation.py1952090%135, 159, 162–165, 171, 283, 308–310, 315, 325–326, 330, 365, 371–372, 405, 421–432
TOTAL174814692% 

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 44.322s ⏱️

@gomezzz
Copy link
Collaborator

gomezzz commented Jul 11, 2023

closed as inactive for now

@gomezzz gomezzz closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Anything related to the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically check notebooks run without errors
3 participants