-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React native support #23
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3bcd0af
to
1944fac
Compare
588c040
to
0932061
Compare
0932061
to
acc5032
Compare
a0ff4b3
to
50ca57b
Compare
Coming soon, we put this on the back burner in favor of https://x.com/aidenybai/status/1861079416480383159, but we're hoping to ship this soon! Only todo is to make sure we don't bloat your production bundle with 6mb of react-native-skia (probably requires a metro plugin) |
b765799
to
99fb610
Compare
99fb610
to
6fad4f6
Compare
For my curious readers 😇 here's what it should look like: https://x.com/aidenybai/status/1861612714537427045 ssstwitter.com_1732702337955.mp4 |
45ef773
to
b0e2dad
Compare
Hi, for now my app is crashing with "Maximum call stack size exceeded" when I try to use it with Tamagui. I know that it's still in development and in early adoption, but it would be so nice to have it work together. |
Checking this out! |
i'm not using it with tamagui and getting max call stack error too RangeError: Maximum call stack size exceeded, js engine: hermes |
Here is the question that comes from my software team: Would there any web or any project be to store scanning data of the project. So that, we can put react-scanner into our pipelines. |
Essentially JS thread is running at zero FPS, react scan takes all CPU power away. |
I have some ideas for performance improvements, will keep thread updated when progress is made |
@AleCatSS Greetings, you probably missed something during the installation process. I think you should check it again. Because I was able to install it without any problems. But I am encountering errors on native codes. |
got it working thanks, for some reason 'react-native-skia' pod was not installed |
Currently It's so laggy and I can't click some stuff like inputs |
should RN skia be installed as a dev deps, since we don't really use it in production ? |
Update on existing bugs relating to max call stack exceeded and perf issues max call stack problemhave fix, will be in a future release perf issues
We have some other backlog items for react scan before I will get to fixing the perf problems, so contributions/suggestions welcome till then :) |
Please improve perf, it's not usable right now, great job, love the library! |
This is good, Can't wait for this to be released ! |
Since react native 0.76, you can try the new react native devtools, just type |
hi boss, Can I not use react-native-reanimated? I think maybe many people are like us and cannot use react-native-reanimated for some reason |
Currently its required, but most likely in the next release for react-scan@native we will drop this requirement |
7526d13
to
47c46ca
Compare
any dice? |
Hi! We're ready to show you an early preview of React Scan for Native. It's not 100% feature parity with web yet, and a lot of technical decisions are up for change, but we'd love for you to try it out.
SimulatorScreenRecording-iPhone16-2024-11-27at16.25.23-ezgif.com-crop-video.mp4
Setup guide
First, install the required dependencies:
Then, wrap your root component with
ReactScan
:The React Native version supports most of the options described in the API Reference section below, with a few differences:
playSound
,runInProduction
,includeChildren
,onPaintFinish
, andonPaintStart
Example usage with options:
Important
By default, Metro bundler includes React Scan in production builds, which can add up to 6MB to your bundle size. To prevent this, use our babel plugin:
If you are not using expo, install expo-babel-preset (works outside of expo):
npm install babel-preset-expo
Create or modify your
babel.config.js
:This will automatically remove React Scan from production builds while keeping it available during development.
Contributing
Please leave all React Native bugs/feedback within this PR until it is merged.
To setup:
You'll need to create a React Native test repo to get it spun up