Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] added step in pipeline #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antter
Copy link
Contributor

@antter antter commented Nov 15, 2021

Related Issues and Dependencies

Fixes #421

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

It adds the Trino table update step to the metrics gathering pipeline. Note that this pipeline now can't run without the TRINO_USER and TRINO_PASSWD being put in. WIP because there hasn't been a KFP available to test it.

Description

Just added the create_trino_tables notebook to be run after all the metric notebooks are run.

@sesheta sesheta added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2021
@sesheta
Copy link
Contributor

sesheta commented Nov 15, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign chauhankaranraj after the PR has been reviewed.
You can assign the PR to them by writing /assign @chauhankaranraj in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@antter antter force-pushed the trino_tables_update branch from c88e180 to c626c70 Compare November 18, 2021 14:37
@sesheta
Copy link
Contributor

sesheta commented Nov 18, 2021

@antter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit c626c70 link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Trino table creation step to KF Pipeline for Testgrid
4 participants