-
-
Notifications
You must be signed in to change notification settings - Fork 27
macos Digit keys handler when alt (option) is pressed #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you explain a little what is the problem with digits? What codes uses Mac? |
|
@ai
I will also put the tests for it later |
|
Can we add the fix as separated if-block since this block is for wrong keyboard layout. Mixing two fixes in one if-block can be bad for maintaince. |
|
Okay, I will separate it, that makes sense |
|
though no, this also refers to a wrong layout, such as with alt, since on macos, as far as I can see, key changes due to holding alt(option) for a special character. Without alt(option) it's not necessary, checkHotkey detects everything correctly as it is |
|
This is because macos changes key to special characters when alt is pressed, but for non_english layouts the code only checks for
It is also connected with that issue #54 |
|
@ai Hi, waiting for your review |
|
Thanks. Fixed in 0.11.2. |

Closes #56