docs: Clarify the --max-local-prefill-length help description #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthui
requested review from
a team,
GuanLuo,
PeaBrane,
alec-flowers,
biswapanda,
grahamking,
hhzhang16,
hutm,
ishandhanani,
julienmancuso,
kkranen,
mohammedabdulwahhab,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
rmccorm4,
ryanolson,
sshchoi,
tanmayv25,
tedzhouhk and
tmonty12
as code owners
nnshah1
reviewed
Apr 8, 2025
Co-authored-by: Neelay Shah <neelays@nvidia.com> Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
nnshah1
approved these changes
Apr 8, 2025
Contributor
nnshah1
left a comment
nnshah1
left a comment
There was a problem hiding this comment.
LGTM - and makes it clearer.
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
tanmayv25
reviewed
Apr 8, 2025
Co-authored-by: Tanmay Verma <tanmayv@nvidia.com> Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
tanmayv25
reviewed
Apr 8, 2025
Co-authored-by: Tanmay Verma <tanmayv@nvidia.com> Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
…amo#554) Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com> Co-authored-by: Neelay Shah <neelays@nvidia.com>
oandreeva-nv
pushed a commit
that referenced
this pull request
Apr 22, 2025
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com> Co-authored-by: Neelay Shah <neelays@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Update the --max-local-prefill-length description making it more descriptive on what it does, and align the description style with the --max-prefill-queue-size below.
Details:
N/A
Where should the reviewer start?
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)