This repository has been archived by the owner on Apr 21, 2021. It is now read-only.
WIP: Node split #15
Open
WIP: Node split #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
reviewed
Jun 10, 2019
ahopkins
reviewed
Jun 10, 2019
ahopkins
reviewed
Jun 10, 2019
|
Addressed some of the comments. I would still like to add more tests before merging this in, but one of the major contributors to untested code metrics is the existence of I don't know if you want to improve the code coverage as part of this pull request or not, but I'm willing to wait for a merge to get some of that done, and make it more safe. |
ahopkins
reviewed
Jun 13, 2019
| @@ -136,6 +136,10 @@ class Node(metaclass=NodeMeta): | |||
| _instances = dict() | |||
| _staged = dict() | |||
|
|
|||
| # uid is not used as a class variable, it is part of the required | |||
| # schema of a Node, and is thus part of the superclass. | |||
| uid : int | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12
I'm a little bit worried about "just" passing tests, without a more comprehensive test suite, considering that I was very much just fixing bugs as the tests revealed them, but this passes tests.
I put this on top of the string escaping, because I didn't want to deal with the inevitable conflicts.