Added "note off" support for buttons #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a note off event. If the OSC string includes the token "$1", - an additional OSC event will be sent when the button is released, - $1 will be replaced with '1' when the button is pressed and '0' when it is released. Additionally, i have added '$1' to the default OSC string.
Additionally, i've made the buttons in the templates distinct by changing the first parameter from "1" to a different number for each button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added "note off" support for the "button" control, by adding a $1 parameter to the OSC string
which will be set to 1 or 0, depending on whether the button was pressed or released.
If $1 is not present in the OSC string, only the "pressed" event will be sent.