Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes jump-window #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes jump-window #150

wants to merge 1 commit into from

Conversation

agzam
Copy link
Owner

@agzam agzam commented Nov 5, 2021

Bug discovered while testing #149. Upstream. Looks like it's broken in Hammerspoon. Removed usage of the experimental module.

#149 (comment)

@agzam agzam added bug upstream upstream bug, due to changes in dependent project(s) labels Nov 5, 2021
@jaidetree jaidetree self-requested a review November 5, 2021 06:53
Copy link
Collaborator

@jaidetree jaidetree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this fix a shot but doesn't seem to be working. Seems like without the filter, it's unable to find the intended target.

@Grazfather
Copy link
Collaborator

What version of Hammerspoon did you discover this on? I noticed there was an update just yesterday.

@agzam
Copy link
Owner Author

agzam commented Nov 5, 2021

I'm using Hammerspoon Version 0.9.91 (6078)
I have not upgraded OS to Monterey yet, supposedly they made some fixes for it.
I guess it broke very recently. Then let's not merge this thing just yet.
Like Sun Tzu would've said: "If you wait by the river long enough, you may see fixed bugs floating by."

@HyunggyuJang
Copy link
Contributor

HyunggyuJang commented Dec 12, 2021

I encountered the same issue, and was able to resolve with HyunggyuJang@dbb12cd

I’m not sure it is the canonical solution and works for all, so I’d like to know your opinions about it!

@agzam
Copy link
Owner Author

agzam commented Dec 17, 2021

For me - both cases work. And whatever is in the master branch - doesn't. Even though I'm now using version 0.9.93 (6148) - it's still broken. At this point, I think we have to merge a fix - using either method. However, I've noticed another thing - after jumping to the target window, Spacehammer menu doesn't go away. That looks like a regression. I'll check what's going on there.

@Grazfather
Copy link
Collaborator

I can't repro on 6172. Do you still have this issue?

@agzam
Copy link
Owner Author

agzam commented Feb 1, 2022

I can't repro on 6172. Do you still have this issue?

The latest available release is 0.9.93 (6148) - both on GitHub and via brew. How did you get 6172?

@Grazfather
Copy link
Collaborator

It was created to test a fix for an issue I reported Hammerspoon/hammerspoon#3081 https://github.com/Hammerspoon/hammerspoon/actions/runs/1726174041

@Grazfather
Copy link
Collaborator

Is this still needed?

@agzam
Copy link
Owner Author

agzam commented May 3, 2023

Is this still needed?

Yes, jump to window appears broken in master. But this "fix" doesn't seem to be fixing it for good. It works, but not reliably.

@jaawerth jaawerth mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream upstream bug, due to changes in dependent project(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants