-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes jump-window #150
base: master
Are you sure you want to change the base?
fixes jump-window #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this fix a shot but doesn't seem to be working. Seems like without the filter, it's unable to find the intended target.
What version of Hammerspoon did you discover this on? I noticed there was an update just yesterday. |
I'm using Hammerspoon Version 0.9.91 (6078) |
I encountered the same issue, and was able to resolve with HyunggyuJang@dbb12cd I’m not sure it is the canonical solution and works for all, so I’d like to know your opinions about it! |
For me - both cases work. And whatever is in the master branch - doesn't. Even though I'm now using version 0.9.93 (6148) - it's still broken. At this point, I think we have to merge a fix - using either method. However, I've noticed another thing - after jumping to the target window, Spacehammer menu doesn't go away. That looks like a regression. I'll check what's going on there. |
I can't repro on 6172. Do you still have this issue? |
The latest available release is 0.9.93 (6148) - both on GitHub and via brew. How did you get 6172? |
It was created to test a fix for an issue I reported Hammerspoon/hammerspoon#3081 https://github.com/Hammerspoon/hammerspoon/actions/runs/1726174041 |
Is this still needed? |
Yes, jump to window appears broken in |
Bug discovered while testing #149. Upstream. Looks like it's broken in Hammerspoon. Removed usage of the experimental module.
#149 (comment)