Read chunked data from companion server #402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
While developing a new parser for competitive companion, a strange bug occurred where some problems did not consistently get transferred. Thinking that the problem was with the parser, this was investigated first. However, all problems were successfully sent.
Other companion clients were able to receive the problems, so I investigated cph. When not ignoring the error, the
JSON.parse
was throwingError parsing problem from companion "SyntaxError: Incomplete string in JSON at position 64975"
.This indicated that the buffer of the
read()
call was full and only a single chunk of data was being read. This only appeared on problems where the parsed test data was large enough to trigger this.Solution
Changing the listener to
data
and parsingchunk
now works for all submitted problems and contests.