fix: Report bad usage to stderr #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
reviewed
Jun 12, 2023
| fprintf(file, "\t-h: print this help message\n"); | ||
| fprintf(file, "\t-i <interval>: metering interval (default to 1)\n"); | ||
| fprintf(file, "\t-l <limit>: metering limit (default to none)\n"); | ||
| fprintf(file, "\t-s <size>: parser buffer size, in kB (default to 8192)\n"); |
Collaborator
There was a problem hiding this comment.
Suggested change
| fprintf(file, "\t-s <size>: parser buffer size, in kB (default to 8192)\n"); | |
| fprintf(file, "\t-n: print worker interface codename\n"); | |
| fprintf(file, "\t-s <size>: parser buffer size, in kB (default to 8192)\n"); |
Collaborator
There was a problem hiding this comment.
@kriskowal Please ping me back when you have adopted something like this, and I'll rereview.
Collaborator
Author
There was a problem hiding this comment.
Pardon, my attention has been elsewhere. Will post.
Collaborator
|
Actually, it was |
Co-authored-by: Michael FIG <[email protected]>
michaelfig
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating #42, we discovered that
agd mnemonicdepended onxsnap -vto be implemented, but since that feature was in another branch,xsnap -vprinted out the usage error information to stdout, in place of the version information.This change causes
xsnap -hto write the usage to stdout, and all bad usage errors to write the same message to stderr.