Added psutils dependency. Previously this required a locally installed version. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoessling
requested changes
Mar 20, 2022
Owner
agoessling
left a comment
agoessling
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Highlights the need for a hermetic python toolchain. I have a couple of comments related to the dependencies in WORKSPACE.
|
|
||
| rules_vivado_indirect_deps() | ||
|
|
||
| http_archive( |
Owner
There was a problem hiding this comment.
Could this go in rules_vivado_direct_deps()?
| ], | ||
| ) | ||
|
|
||
| load("@rules_python//python:pip.bzl", "pip_parse") |
Owner
There was a problem hiding this comment.
This could go in rules_vivado_indirect_deps()?
| requirements_lock = "//:requirements.txt", | ||
| ) | ||
|
|
||
| load("@pip//:requirements.bzl", "install_deps") |
Owner
There was a problem hiding this comment.
And this would have to go in rules_vivado_deps_level_3()... Maybe it's time to look into bzlmod. In the past I've named these with numbers to avoid this problem. Or we could pull them all out of the macros and into here. Thoughts? At minimum we need to update the README to show what to do for dependent projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull psutils from pip, instead of requiring a local installed version.