Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Scanner config multiple saves. #379

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: Scanner config multiple saves. #379

merged 1 commit into from
Nov 13, 2024

Conversation

agittins
Copy link
Owner

  • Fixes Reduce logging - remove save config at info level Reduce logging - remove save config at info level #364
  • Fixes How to remove entities for proxies that no longer exist How to remove entities for proxies that no longer exist #214
  • Stops Bermuda doing multiple save-outs to config_entry.data for scanner configs.
  • Fixes a lot of reload-churn during initial startup, Bermuda now only loads once if the scanner setup hasn't changed.
  • Likely fixes some race-condition-based performance / lockup issues that might have happened very occasionally.
  • Only save the necessary fields out for scanner info, to avoid ephemeral data causing extra reloads.
  • This plus the change to scanner identification in previous release resolves being unable to remove entities on devices that relate to non-present scanners (or scanners that are no longer scanners).
  • Bonus fix, include IRK devices in action bermuda.dump_devices when configured_devices is set.

@agittins
fix: Scanner config multiple saves.
25277cf 
- Fixes Reduce logging - remove save config at info level #364
- Fixes How to remove entities for proxies that no longer exist #214
- Stops Bermuda doing multiple save-outs to config_entry.data for scanner configs.
- Fixes a lot of reload-churn during initial startup, Bermuda now only loads once if the scanner setup hasn't changed.
- Likely fixes some race-condition-based performance / lockup issues that might have happened very occasionally.
- Only save the necessary fields out for scanner info, to avoid ephemeral data causing extra reloads.
- This plus the change to scanner identification in previous release resolves being unable to remove entities on devices that relate to non-present scanners (or scanners that are no longer scanners).
- Bonus fix, include IRK devices in action `bermuda.dump_devices` when `configured_devices` is set.
@agittins agittins merged commit 841bf87 into main Nov 13, 2024
6 checks passed
@agittins agittins deleted the ajg-fix-scanner-saveouts branch November 13, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agittins