Linting, typing and comments

custom_components/bermuda/bermuda_device.py

@@ -130,8 +130,8 @@ def __init__(self, address, options) -> None:
 
     def set_ref_power(self, value: float):
         """
-        Set a new reference power for this device and apply an interim
-        distance calculation.
+        Set a new reference power for this device and immediately apply
+        an interim distance calculation.
         """
         self.ref_power = value
         nearest_distance = 9999  # running tally to find closest scanner

custom_components/bermuda/bermuda_device_scanner.py

@@ -64,8 +64,8 @@ def __init__(
         self.adapter: str = scandata.scanner.adapter
         self.address = scanner_device.address
         self.source: str = scandata.scanner.source
-        self.area_id: str = scanner_device.area_id
-        self.area_name: str = scanner_device.area_name
+        self.area_id: str | None = scanner_device.area_id
+        self.area_name: str | None = scanner_device.area_name
         self.parent_device = parent_device
         self.parent_device_address = parent_device.address
         self.scanner_device = scanner_device  # links to the source device
@@ -105,10 +105,10 @@ def update_advertisement(self, scandata: BluetoothScannerDevice):
         claims to have data.
         """
         # In case the scanner has changed it's details since startup:
-        self.name: str = scandata.scanner.name
-        self.area_id: str = self.scanner_device.area_id
+        self.name = scandata.scanner.name
+        self.area_id = self.scanner_device.area_id
         self.area_name = self.scanner_device.area_name
-        new_stamp: float | None = None
+        new_stamp = None
 
         # Only remote scanners log timestamps here (local usb adaptors do not),
         if hasattr(scandata.scanner, "_discovered_device_timestamps"):
@@ -361,9 +361,7 @@ def calculate_data(self):
                             # (not so for == 0 since it might still be an invalid retreat)
                             break
 
-                    if velocity > peak_velocity:
-                        # but on subsequent comparisons we only care if they're faster retreats
-                        peak_velocity = velocity
+                    peak_velocity = max(velocity, peak_velocity)
                 # we've been through the history and have peak velo retreat, or the most recent
                 # approach velo.
                 velocity = peak_velocity

custom_components/bermuda/number.py

@@ -111,6 +111,11 @@ async def async_set_native_value(self, value: float) -> None:
         """Set value."""
         self.coordinator.devices[self.address].set_ref_power(value)
         self.async_write_ha_state()
+        # Beware that STATE_DUMP_INTERVAL for restore_state's dump_state
+        # is 15 minutes, so if HA is killed instead of exiting cleanly,
+        # updated values may not be restored. Tempting to schedule a dump
+        # here, since updates to calib will be infrequent, but users are
+        # moderately likely to restart HA after playing with them.
 
     @property
     def unique_id(self):