Skip to content

Conversation

@ShenJunkun
Copy link

AgentScope-Java Version

io.agentscope:agentscope-parent:pom:1.0.7-SNAPSHOT

Description

Background

This PR addresses #236 by implementing ElasticSearch as a dedicated storage backend for the RAG (Retrieval-Augmented Generation) pipeline. While the system previously supported other vector stores, this integration allows users to leverage ElasticSearch's enterprise-grade scalability, hybrid search capabilities, and robust document management.

Key Changes

  • Added ElasticsearchStore.java: Implemented the core logic for the vector store, including document indexing and retrieval functionality.
  • Comprehensive Testing:
    • Added ElasticsearchTest.java for unit testing core components.
    • Added ElasticsearchRAGExample.java as an end-to-end test case to demonstrate the full RAG workflow.
  • Documentation Updates: Updated the docs directory with both English and Chinese documentation to reflect the new integration.

Checklist

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@ShenJunkun ShenJunkun requested a review from a team January 10, 2026 07:06
@cla-assistant
Copy link

cla-assistant bot commented Jan 10, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Jan 10, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 80.78603% with 44 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../agentscope/core/rag/store/ElasticsearchStore.java 80.78% 24 Missing and 20 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements Elasticsearch as a vector store backend for the RAG pipeline, enabling enterprise-grade vector search capabilities with scalable document management.

Changes:

  • Added ElasticsearchStore implementation with document indexing, kNN search, and deletion operations
  • Comprehensive unit tests using Mockito for core functionality validation
  • End-to-end example (ElasticsearchRAGExample) demonstrating RAG workflow with Elasticsearch
  • Updated documentation (English and Chinese) to reflect the new Elasticsearch integration
  • Added Elasticsearch Java client dependency (version 8.12.0) to the BOM and relevant modules

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
ElasticsearchStore.java Core vector store implementation with kNN search and bulk operations
ElasticsearchStoreTest.java Comprehensive unit tests covering builder validation, CRUD operations, and edge cases
ElasticsearchRAGExample.java End-to-end example demonstrating Elasticsearch RAG integration
docs/zh/task/rag.md Chinese documentation updated with Elasticsearch store information
docs/en/task/rag.md English documentation updated with Elasticsearch store information
docs/zh/quickstart/installation.md Chinese installation guide updated with Elasticsearch dependency
docs/en/quickstart/installation.md English installation guide updated with Elasticsearch dependency
agentscope-dependencies-bom/pom.xml Added Elasticsearch client version management
agentscope-examples/advanced/pom.xml Explicit Elasticsearch version declaration to override Spring Boot BOM
agentscope-extensions/agentscope-extensions-rag-simple/pom.xml Added Elasticsearch Java client dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AlbumenJ
Copy link
Collaborator

Please check copilot's review

@ShenJunkun
Copy link
Author

I’m working on the Copilot review edits; I’ll be done soon.

@AlbumenJ
Copy link
Collaborator

image Please resolve these conficts :)

@ShenJunkun
Copy link
Author

All conflicts have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants