feat: update base/openai chat model module

[jc200808]

OpenJudge Version

[The version of OpenJudge you are working on, e.g. import openjudge; print(openjudge.__version__)]

Description

[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

• Code has been formatted with pre-commit run --all-files command
• All tests are passing
• Docstrings are in Google style
• Related documentation has been updated (e.g. links, examples, etc.)
• Code is ready for review

[gemini-code-assist]

Summary of Changes

Hello @jc200808, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several enhancements and fixes to the base and OpenAI chat model modules. It focuses on improving the robustness of tool choice validation, refining audio data formatting for Qwen-omni models to ensure correct base64 prefixing and immutability, and enhancing the management of structured output requests for Qwen models by providing warnings and defaulting to a compatible JSON object format. These updates aim to improve the reliability and compatibility of the chat model integrations.

Highlights

• Enhanced Tool Choice Validation: The _validate_tool_choice function has been significantly improved for robustness. This includes converting TOOL_CHOICE_MODES from a list to a set for optimized lookups, adding checks for empty tool_choice strings, and implementing detailed validation of the tools structure to ensure correct dictionary and string types for function names.
• Qwen-Omni Audio Data Formatting Refinement: The _format_audio_data_for_qwen_omni function now returns a new list of formatted messages instead of modifying the input in-place. It also incorporates a try-except block for error handling during formatting and ensures the 'data:;base64,' prefix is only added to audio data if it's not already an HTTP link.
• Structured Output Handling for Qwen Models: The achat method now provides specific handling for Qwen models when attempting Pydantic structured output. It logs a warning indicating that Qwen models do not support this via response_format and defaults to an unstructured JSON object format, while correctly applying structured models for other non-Qwen models.
• Altered Tool Choice Validation Trigger: The condition for invoking _validate_tool_choice within the achat method was inverted from if tool_choice: to if not tool_choice:. This means validation will now only occur if tool_choice is a falsy value (e.g., None or an empty string), potentially bypassing validation for explicitly provided tool names.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several improvements to the chat model modules, such as using a set for TOOL_CHOICE_MODES for better performance, enhancing tool_choice validation with more robust checks and clearer error messages, and correctly handling structured output for Qwen models. The refactoring of _format_audio_data_for_qwen_omni to avoid side effects is a good direction, but the implementation is flawed as it uses a shallow copy and has suboptimal exception handling. More critically, there's a logic inversion in the achat method for tool_choice validation that will lead to runtime errors. I've provided suggestions to address these issues.