Skip to content

Conversation

@benbrandt
Copy link
Member

Proposing to move this to the Completed stage!

@benbrandt benbrandt requested a review from a team as a code owner January 27, 2026 12:10
@chazcb
Copy link
Contributor

chazcb commented Jan 27, 2026

@benbrandt would love if you took a quick look at #393 and the different config schema there. It might make sense to consolidate the way we define config schemas together.

@benbrandt
Copy link
Member Author

@chazcb a few thoughts:

  • First: sorry for not doing a full review on that one sooner
  • Second: we made session config options possible to add new variants in the future, so I don't think it is at odds
  • Third: Session config options has something yours doesn't yet, which is the ability to have a distinction between values and labels, i.e. a unique ID and a user-facing value, but we can address that on your RFD

@benbrandt benbrandt force-pushed the stabilize-session-config branch from f4a87b1 to 241a963 Compare February 4, 2026 11:49
@benbrandt
Copy link
Member Author

OK going to stabilize this!

@benbrandt benbrandt merged commit 9f453c7 into main Feb 4, 2026
7 checks passed
@benbrandt benbrandt deleted the stabilize-session-config branch February 4, 2026 11:52
@acp-release-bot acp-release-bot bot mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants