Pouvoir archiver un compte bancaire #1896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mopolo
reviewed
Aug 4, 2025
| '6' => 'Livret A CM', | ||
| '4' => 'Paypal', | ||
| ]; | ||
| $listeComptes = $compta->obtenirListeComptesActifs(''); |
There was a problem hiding this comment.
C'est déjà la valeur par défaut donc tu peux enlever la valeur :
Suggested change
| $listeComptes = $compta->obtenirListeComptesActifs(''); | |
| $listeComptes = $compta->obtenirListeComptesActifs(); |
Comment on lines
27
to
28
| $champsRecup = $compta->obtenirListComptes('',$_GET['id']); | ||
| $champs['nom_compte'] = $champsRecup['nom_compte']; |
There was a problem hiding this comment.
Au lieu de modifier ce code, il vaudrait mieux supprimer ce qui a été remplacé par du Symfony (tout sauf la liste des compte).
Là actuellement les anciennes urls de modification et création fonctionnent encore.
Après si tu compte refaire la liste des comptes en Symfony ça peut attendre.
There was a problem hiding this comment.
J'ai une branche locale avec la refonte de la page de listing sous SF. Si besoin, je peux l'intégrer à la PR.
There was a problem hiding this comment.
@Mopolo au final j'ai ajouté la suppression de la page legacy de listing des comptes
6 tasks
stakovicz
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1783 #1831