refacto: migration de l'administration des articles sous Symfony #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgreb
force-pushed
the
refacto/articles
branch
4 times, most recently
from
9203f65 to
767d4a9
Compare
vgreb
commented
Jul 31, 2025
| @@ -38,3 +38,9 @@ | |||
| </div> | |||
| {%- endif -%} | |||
| {%- endblock datetime_widget -%} | |||
|
|
|||
| {%- block textarea_widget -%} | |||
There was a problem hiding this comment.
Il est peut être plus judicieux d'utiliser la macro wysiwyg() présente dans templates/admin/event/form.html.twig, quite à la déplacer dans le form_theme_admin.html.twig.
Qu'en pensez-vous ?
There was a problem hiding this comment.
Si ça rend le code plus clair pourquoi pas.
Attention par contre à si ça modifie beaucoup de fichiers, ce sera mieux de faire ça dans une PR séparée.
vgreb
changed the title
Mopolo
reviewed
Aug 15, 2025
| 'filter' => $article->getTitle(), | ||
| ]); | ||
| } | ||
| dump($article); |
| if ($form->isSubmitted() && $form->isValid()) { | ||
| $this->articleRepository->save($article); | ||
| $this->log('Modification de l\'article ' . $article->getTitle()); | ||
| $this->addFlash('notice', 'L\'article ' . $article->getTitle() . ' a été modifiée'); |
There was a problem hiding this comment.
Suggested change
| $this->addFlash('notice', 'L\'article ' . $article->getTitle() . ' a été modifiée'); | |
| $this->addFlash('notice', 'L\'article ' . $article->getTitle() . ' a été modifié'); |
| private readonly ArticleRepository $articleRepository, | ||
| ) {} | ||
|
|
||
| public function __invoke(int $id,Request $request): Response |
There was a problem hiding this comment.
Suggested change
| public function __invoke(int $id,Request $request): Response | |
| public function __invoke(int $id, Request $request): Response |
Comment on lines
51
to
53
| /** | ||
| * @var int | ||
| */ |
There was a problem hiding this comment.
Tu peux enlever le docblock du coup
Comment on lines
355
to
357
| /** | ||
| * @return int|null | ||
| */ |
| * | ||
| * @return $this | ||
| */ | ||
| public function setPosition($position): self |
There was a problem hiding this comment.
Autant en profiter pour avoir un type natif (et pareil pour authorId)
Suggested change
| public function setPosition($position): self | |
| public function setPosition(?int $position): self |
| return $this; | ||
| } | ||
|
|
||
| public function useMarkdown(): bool |
There was a problem hiding this comment.
Ce serait plus correct comme ça, sinon ça ressemble à un setter.
Suggested change
| public function useMarkdown(): bool | |
| public function usesMarkdown(): bool |
| @@ -239,6 +239,39 @@ public function findNewsBySlug($slug) | |||
| return $events->first(); | |||
| } | |||
|
|
|||
| public function getAllArticlesWithCategoryAndTheme($ordre = 'titre', $direction = 'desc', string $filtre = '%') | |||
There was a problem hiding this comment.
Suggested change
| public function getAllArticlesWithCategoryAndTheme($ordre = 'titre', $direction = 'desc', string $filtre = '%') | |
| public function getAllArticlesWithCategoryAndTheme(string $ordre = 'titre', string $direction = 'desc', string $filtre = '%') |
stakovicz
reviewed
Aug 15, 2025
|
|
||
| if ($form->isSubmitted() && $form->isValid()) { | ||
| $this->articleRepository->save($article); | ||
| $this->log('Ajout de la rubrique ' . $article->getTitle()); |
There was a problem hiding this comment.
Suggested change
| $this->log('Ajout de la rubrique ' . $article->getTitle()); | |
| $this->log('Ajout de l\'article ' . $article->getTitle()); |
vgreb
force-pushed
the
refacto/articles
branch
from
9b338cd to
fa7f862
Compare
vgreb
force-pushed
the
refacto/articles
branch
from
fa7f862 to
78ea080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration de l'administration de articles sous Symfony.
La nouvelle url dans le menu est /admin/site/articles
J'ai volontairement laissé les sources legacy. Si la MR est validée, je ferais une seconde MR pour les supprimer.