OM-209 - latencies command is not working #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this issue is occuring because namespace is append to the latencies command with a "-" and "-" (hypen) is part of the latency command itself, because of this command is constructed wrongly. a quick fix is use a separator which is not part of server command or output like "-","_",":" etc.,
removed unnecessary code, and fixed service hist stats
removed unnecessary comments
as discussed, modified code to have different maps for namespace and service (exception) latency commands. now latency commands are constructed and added while parsing the namespace and node-details
sunilvirus
requested changes
Oct 30, 2024
| @@ -5,7 +5,10 @@ var ( | |||
| Service, ClusterName, Build string | |||
| ) | |||
|
|
|||
| var LatencyBenchmarks = make(map[string]string) | |||
| var NodeLatencyBenchmarks = make(map[string]string) | |||
| var NamespaceLatencyBenchmarks = make(map[string]string) | |||
There was a problem hiding this comment.
Though we do not parse map keys anymore, I still think map of maps is cleaner. any reason why we did not do this ?
There was a problem hiding this comment.
I did that also, but with map of map, we have to do 2 loops, one good thing with the map of map will be the key will be namespace and looks more cleaner
sunilvirus
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this issue is occuring because namespace is append to the latencies command with a "-" and "-" (hypen) is part of the latency command itself, because of this command is constructed wrongly. a quick fix is use a separator which is not part of server command or output like "-","_",":" etc.,