Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add byte rate metrics #111

Closed
wants to merge 3 commits into from
Closed

Add byte rate metrics #111

wants to merge 3 commits into from

Conversation

verdie-g
Copy link
Contributor

For now it's only added to AsyncCommand. Closes #109.

@shannonklaus
Copy link
Collaborator

@verdie-g I have work in progress for adding a metrics feature to the client. There are two parts to it, one of them is the current info in ClusterStats and the second part is extended metrics including transaction count and latency buckets on a per node basis. I can add byte rate metrics to the extended metrics. Since what you are suggesting requires two atomic operations per transaction we don't want to have it enabled by default.

@verdie-g
Copy link
Contributor Author

Since what you are suggesting requires two atomic operations per transaction we don't want to have it enabled by default.

Do you think we could go forward with that PR if I introduced a LowReadHighWriteAtomicCounter like https://gist.github.com/verdie-g/77b58548fa772fef42a710e4aea49576 as discussed in dotnet/runtime#92442?

@shannonklaus
Copy link
Collaborator

No, we would still like to wait until the metrics as I described are implemented and the bytes sent/received should only be enabled when metrics are enabled by the user.

@verdie-g
Copy link
Contributor Author

Got it. Would you have an idea when these metrics could be available?

@shannonklaus
Copy link
Collaborator

I am currently planning on including it in the April release, which should be toward the end of April.

@verdie-g verdie-g closed this by deleting the head repository May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectionStats.Bytes{Read/Written}
2 participants