Allowing inner Exception to be null in AerospikeException constructor #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several AerospikeException.Timeout constructors take an optional null inner exception and use this constructor. Right now, using these AerospikeException.Timeout constructors will result in an "Object reference not set to an instance of an object" error if no inner exception is given.
|
Hello @shannonklaus, how are you ? Could I ask for a review on this ? Thank you for your time ! |
|
Thank you for your pull request. This change will be included in the next release, which I expect will be in a few weeks or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several AerospikeException.Timeout constructors take an optional inner exception, by default null.
However they use this AerospikeException constructor for their base classes, which can't deal with a null Exception argument.
Right now, using these AerospikeException.Timeout constructors without specifying an Inner Exception will result in an "Object reference not set to an instance of an object" error if no inner exception is given.
This happens at several places at least within Aerospike.Client.AsyncCommand.cs.