-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix travis #4
base: 7.x-3.x
Are you sure you want to change the base?
Fix travis #4
Conversation
@jonpugh can we run the install with --verbose? or even debug? |
@helmo That would be good for testing, but not for local development or production docker. Maybe we can create a separate "tag" for a docker image with extra debug info. Go ahead and submit a PR for the "dockerfiles" repo, alter the I'm ok with making that an easy option, but I think keeping the docker logs clean is better developer experience (once we have stable containers of course.) |
I tracked down when Hostmaster started failing: https://travis-ci.org/aegir-project/hostmaster/builds/150880346 It was when we committed node_access_rebuild(). 84db208...b90c772 So I'm going to test out removing it. |
meh, as I feared, the problem is not in the commit, but in a change to tests or dockerfiles... At least we know the timestamp now :) |
Ok, this seems like a problem with drush make itself. I've narrowed down the issue to profile projects using the "copy" download type. See this issue: drush-ops/drush#2311 (comment) |
Try manually building the |
Ok, I found the workaround needed for the makefile. Here it goes! |
And that's why we test failures! The tests were not using the local makefile. I believe I have fixed this by setting all environment variables for the run of docker-entrypoint.sh inside docker-entrypoint-tests.sh |
That last commit added a lot of noise ... but I hope it helps find our bug or typo. |
This avoids running them twice for each PR update.
Fixing travis yml.
Use the new 'prepare-docker.sh' script, and the docker-compose-hostmaster.yml file.