-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New View: Server Stats #3335
base: master
Are you sure you want to change the base?
New View: Server Stats #3335
Conversation
…q.library asignment
cant this just be a toggle on the stats page to include all libraries? |
I wouldn't recommend making this change. Although the design may appear similar, the "library stats" are actually located on the left-hand side of the current page, not in the settings, since they pertain specifically to this library. Having the label in the settings is, in my opinion, incorrect (and frustrating when navigating through pages and getting redirected), since it was recently moved. Since "all libraries stats" are independent of the selected libraries, I suggest removing the incorrect button from the settings instead and having a button for all stats. |
I'm not a fan of merging podcast library and audiobook library stats and using the same stat info. What is the motivation for an all library stats page? What is the data you are actually interested in seeing across all libraries? |
Are there specific reasons for this? Generally, this overview should be an overview of all media on the server. In principle, I think it would be a quick task to differentiate between podcast and book media types, and then add up all podcasts for a podcast library and all books for book libraries. But I don't quite understand exactly why (Yes, podcasts are usually longer and larger), but that's basically irrelevant for the overall overview. Perhaps, and this would solve the problem, each episode could be considered as an item for the statistics. But I am open to change that |
I did some research about the CodeQL failure because that seems to be unrelated to this PR. For reference, the error is from I've found two main ways to fix it. Both are working in my local testing.
|
Waking up to an email starting with "Stealing the image you posted" ^^. I fixed the clicking issue. Now it should switch and display the correct library. @advplyr I'm not sure if this is the proper way to do it—I just borrowed the code from the library switcher. I also reverted the changes I made to the library stats view. |
Apologies, didn't think about how that would show up in an e-mail. Just tested and switching to the correct library is working for me. |
Based on #3330
This PR introduces a new page titled "All Libraries Stats," which mirrors the existing "Library Stats" view but combines data from all libraries.
We might want to consider refactoring the design since this results in some duplicated code. While there are slight modifications, primarily in the computed section, much of the functionality remains the same.
Image: