Skip to content

PocketMine-MP has improperly handled dye colour IDs in banner NBT, leading to server crash

High severity GitHub Reviewed Published Jan 6, 2023 in pmmp/PocketMine-MP • Updated Jan 9, 2023

Package

composer pocketmine/pocketmine-mp (Composer)

Affected versions

< 4.8.1

Patched versions

4.8.1

Description

Impact

DyeColorIdMap->fromId() did not account for the possibility that it might be given invalid input. This means that an undefined offset error would occur whenever this happened.

This code is indirectly called during Banner->deserializeCompoundTag(), which is invoked when deserializing any item NBT, whether from network or disk.

An attacker could use this bug to crash a server by providing NBT with invalid values for pattern colours in an inventory transaction, or by using /give to obtain an item with NBT like this.

Patches

08b9495bce2d65a6d1d3eeb76e484499a00765eb

Workarounds

This is quite difficult to work around via a plugin. Theoretically, it's possible to override the Banner item class from a plugin and validate the data before it reaches deserializeCompoundTag().

For more information

If you have any questions or comments about this advisory:

References

@dktapps dktapps published to pmmp/PocketMine-MP Jan 6, 2023
Published to the GitHub Advisory Database Jan 9, 2023
Reviewed Jan 9, 2023
Last updated Jan 9, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

Weaknesses

No CWEs

CVE ID

No known CVE

GHSA ID

GHSA-wqqv-jcfr-9f5g

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.