Skip to content

Improperly checked IDs on itemstacks received from the client leading to server crash in PocketMine-MP

High severity GitHub Reviewed Published Jun 7, 2022 in pmmp/PocketMine-MP • Updated Jan 11, 2023

Package

composer pocketmine/pocketmine-mp (Composer)

Affected versions

>= 4.0.0-BETA5, < 4.4.2

Patched versions

4.4.2

Description

Impact

Due to a workaround for unmapped network items implemented in 4.0.0-BETA5 (8ac16345a3bc099b62c1f5cfbf3b736e621c3f76), arbitrary item IDs are able to be written into an item's NBT. The intended purpose of this is to make said unmapped network items able to be moved around the inventory without issues.

This led to an exploit due to internal limits on the range that item IDs can occupy (-32768 - 32767), while the tag type used to represent the replacement IDs for unknown items is a TAG_Int, allowing a range from -(2^31) - 2^31 - 1. This leads to an uncaught exception which crashes the server.

Patches

5fd685e07d61ef670584ed11a52fd5f4b99a81a7

Workarounds

In theory this can be checked by plugins using a custom TypeConverter, but this is likely to be very cumbersome.

For more information

If you have any questions or comments about this advisory:

References

@dktapps dktapps published to pmmp/PocketMine-MP Jun 7, 2022
Published to the GitHub Advisory Database Jun 7, 2022
Reviewed Jun 7, 2022
Last updated Jan 11, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

Weaknesses

No CWEs

CVE ID

No known CVE

GHSA ID

GHSA-fqx3-r75h-vc89

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.