Fix script reference #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The composite action doesn't automatically download referenced scripts when used in another repository's workflow. By inlining the scripts we resolve the missing script file issue.
This allows us to test the inlined download action as it would be used when the action is used in a different repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #11.
When used as a dependency in another repository the composite Action doesn't automatically make the referenced scripts available. In the test workflow we performed a checkout of the repository before the use of the Action to make the test cases available. This also made the scripts the Action relies upon available so it worked fine.
In this PR we inlined the scripts to resolve this issue.