Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : path traversal for rootBucket #351

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AssahBismarkabah
Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah commented Sep 19, 2024

I updated the StaticRoutBucket. If the resourcePath doesn't start with the bucketName, the method will now return the original path to avoid unintentional removal of later bucket name segments

@AssahBismarkabah AssahBismarkabah linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Sep 20, 2024

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.77%. Comparing base (32d36bc) to head (b1d79e0).

Files with missing lines Patch % Lines
...s/datasafe/storage/impl/s3/StaticBucketRouter.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #351   +/-   ##
==========================================
  Coverage      86.76%   86.77%           
  Complexity         1        1           
==========================================
  Files            164      164           
  Lines           3348     3350    +2     
  Branches         217      218    +1     
==========================================
+ Hits            2905     2907    +2     
  Misses           309      309           
  Partials         134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path traversal if path contains rootbucket
1 participant