Fix: ensure unique iv generation for GCM encryption to prevent reuse error #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #344 +/- ##
==========================================
Coverage 86.76% 86.76%
Complexity 1 1
==========================================
Files 164 164
Lines 3347 3348 +1
Branches 217 217
==========================================
+ Hits 2904 2905 +1
Misses 309 309
Partials 134 134 ☔ View full report in Codecov by Sentry. |
francis-pouatcha
requested changes
Aug 8, 2024
...rc/main/java/de/adorsys/datasafe/encrypiton/impl/cmsencryption/CMSEncryptionServiceImpl.java
Outdated
Show resolved
Hide resolved
|
|
resolved @francis-pouatcha |
francis-pouatcha
approved these changes
Aug 13, 2024
AssahBismarkabah
deleted the
gcm-cipher-cannot-be-reused-for-encryption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
SecureRandomto JceCMSContentEncryptorBuilder in CMSEncryptionServiceImpl to ensure unique IV generation for each encryption operation.