162 add checkstyle and spotbugs into build pipeline #339
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #339 +/- ##
=============================================
+ Coverage 86.14% 86.76% +0.62%
Complexity 1 1
=============================================
Files 165 165
Lines 3348 3348
Branches 217 217
=============================================
+ Hits 2884 2905 +21
+ Misses 330 309 -21
Partials 134 134 ☔ View full report in Codecov by Sentry. |
pom.xml
Outdated
| @@ -123,6 +123,10 @@ | |||
| <maven-gpg-plugin.version>3.1.0</maven-gpg-plugin.version> | |||
| <maven-source-plugin.version>3.0.1</maven-source-plugin.version> | |||
| <nexus-staging-maven-plugin.version>1.6.13</nexus-staging-maven-plugin.version> | |||
| <checkstyle-maven-plugin.version>3.2.0</checkstyle-maven-plugin.version> | |||
There was a problem hiding this comment.
there is already version 3.4.0
There was a problem hiding this comment.
i will update the version here too
| <consoleOutput>true</consoleOutput> | ||
| <failsOnError>true</failsOnError> | ||
| <linkXRef>false</linkXRef> | ||
| <outputFile>${project.basedir}/target/checkstyle-report.xml</outputFile> |
There was a problem hiding this comment.
please add
<propertyExpansion>org.checkstyle.google.severity=warning</propertyExpansion>
So we can make it more strict later by changing to error
There was a problem hiding this comment.
Great i will correct that, and push before merging
|
forkimenjeckayang
deleted the
162-add-checkstyle-and-spotbugs-into-build-pipeline
branch
Added the Checkstyle and Spotbugs plugin to pom.xml for static code analysis