-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename datasafe simple adapter spring test files #330
Rename datasafe simple adapter spring test files #330
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #330 +/- ##
=============================================
+ Coverage 85.81% 86.34% +0.53%
Complexity 1 1
=============================================
Files 165 165
Lines 3342 3340 -2
Branches 216 214 -2
=============================================
+ Hits 2868 2884 +16
+ Misses 338 326 -12
+ Partials 136 130 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AssahBismarkabah It looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SimpleDatasafeAdapterTest this test uses minio docker image and quite heavy. So should be IT
...apter-impl/src/test/java/de/adorsys/datasafe/simple/adapter/impl/SimpleAdapterFeatureIT.java
Outdated
Show resolved
Hide resolved
...spring/src/test/java/de/adorsys/datasafe/simple/adapter/spring/InjectionForFilesystemIT.java
Outdated
Show resolved
Hide resolved
updated @max402 |
@@ -39,7 +39,7 @@ | |||
|
|||
@Slf4j | |||
class SimpleAdapterFeatureTest extends BaseMockitoTest { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure that classes remain untouched when undoing changes
Renamed Datasafe simple Adapter spring test files to separate integration tests from unit tests using the profile ID
IT