Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename datasafe simple adapter spring test files #330

Merged

Conversation

AssahBismarkabah
Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah commented Jul 9, 2024

Renamed Datasafe simple Adapter spring test files to separate integration tests from unit tests using the profile ID IT

@AssahBismarkabah AssahBismarkabah linked an issue Jul 9, 2024 that may be closed by this pull request
@AssahBismarkabah AssahBismarkabah self-assigned this Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (c456aca) to head (abfc380).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #330      +/-   ##
=============================================
+ Coverage      85.81%   86.34%   +0.53%     
  Complexity         1        1              
=============================================
  Files            165      165              
  Lines           3342     3340       -2     
  Branches         216      214       -2     
=============================================
+ Hits            2868     2884      +16     
+ Misses           338      326      -12     
+ Partials         136      130       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Thendo20 Thendo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AssahBismarkabah It looks good to me

Copy link
Collaborator

@max402 max402 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SimpleDatasafeAdapterTest this test uses minio docker image and quite heavy. So should be IT

@AssahBismarkabah
Copy link
Collaborator Author

updated @max402

@@ -39,7 +39,7 @@

@Slf4j
class SimpleAdapterFeatureTest extends BaseMockitoTest {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure that classes remain untouched when undoing changes

@AssahBismarkabah AssahBismarkabah merged commit bcf23f5 into develop Jul 15, 2024
3 checks passed
@AssahBismarkabah AssahBismarkabah deleted the rename-datasafe-simple-adapter-spring-test-files branch July 15, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rename datasafe-simple-adapter-spring Test files
3 participants