185 more restrictive api for string arguments #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
forkimenjeckayang
commented
Jul 1, 2024
•
forkimenjeckayang
commented
- Modified some REST APIs in datasafe-rest-impl to enhance security with input / parameter validation
…rect name used when referenced
…rect name used when referenced
|
It looks like original issue was fixed long time ago. URI was replaced with url-safe Uri wrapper class. The TODO in BasePrivateResource can be removed. |
|
Noted Sir @max402 , i noticed too that's why there was little or nothing to do with the rest apis in datasafe-rest-impl. And by removing the TODO in BasePrivateResource you mean everything from line 30 and below or just the 1 arg constructor ? |
|
@forkimenjeckayang No, I mean remove only the TODO comment line |
|
Oh okay , just from doing that. |
max402
approved these changes
Jul 10, 2024
|
@forkimenjeckayang please rebase you branch on top of current develop |
|
OK @max402 , i have done that |
|
Hello @max402 Should i go ahead and merge then close or you will do it |
forkimenjeckayang
deleted the
185-more-restrictive-api-for-string-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.