Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

293-rename-datasafe-business-integration-test-files-for-clear-separation #302

Merged
merged 11 commits into from
Apr 17, 2024
Merged

293-rename-datasafe-business-integration-test-files-for-clear-separation #302

merged 11 commits into from
Apr 17, 2024

Conversation

Elwizzy12
Copy link
Collaborator

No description provided.

@Elwizzy12 Elwizzy12 linked an issue Apr 11, 2024 that may be closed by this pull request
Rename datasafe-business Integration Test Files for Clear Separation #293
Closed
5 tasks
@francis-pouatcha francis-pouatcha self-assigned this Apr 11, 2024
francis-pouatcha
francis-pouatcha reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@francis-pouatcha francis-pouatcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class need to be renamed to SchemaDelegationIT as it uses testcontainers.

francis-pouatcha
francis-pouatcha reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@francis-pouatcha francis-pouatcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class name and File name have to match.

francis-pouatcha
francis-pouatcha requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@francis-pouatcha francis-pouatcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the class name

@Elwizzy12
Copy link
Collaborator Author

Class name and File name have to match.

okay sir thanks for the correction, working on it!

Elwizzy12 and others added 3 commits April 12, 2024 11:06
@Elwizzy12
changed integration test with suffix IT
04602ea
@francis-pouatcha
Merge pull request #309 from adorsys/develop
2eff06e 
Merge work done so far to improve code coverage.
@francis-pouatcha
Merge pull request #313 from adorsys/develop
e27253e 
Adding -PIT profile to increase test coverage
@francis-pouatcha francis-pouatcha merged commit fbcfa91 into develop Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francis-pouatcha francis-pouatcha francis-pouatcha approved these changes

Assignees

@Elwizzy12 Elwizzy12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename datasafe-business Integration Test Files for Clear Separation
2 participants
@Elwizzy12 @francis-pouatcha