Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue with subsequent value updates not being tracked if the… #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dxmo
Copy link

@dxmo dxmo commented Mar 3, 2022

… value was set to null

fixes #643

@snewcomer
Copy link
Collaborator

@dxmo Looks like some test failures

@dxmo
Copy link
Author

dxmo commented Mar 7, 2022

@snewcomer I've had a further look and while my PR somewhat address the issue for me, its not a valid fix - please ignore it and apologies.

However, I was able to track this down to ember-changeset, specifically the value is actually not being set on the object at all - I have no idea why would that be at the moment. Still trying to understand it ... but essentially the code bellow does not result in the object being updated with the passed value. I understand safeGet is actually Ember.set() which makes it all the more suspicious ..

line 63 : ember-changeset/addon/index.js:

  safeSet(obj, key, value) {
    return safeSet(obj, key, value);
  }

@snewcomer
Copy link
Collaborator

@dxmo Thanks for the update! If there was a failing test your could write and push to a PR, that would help greatly in finding a solution for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants