This repository was archived by the owner on Jun 8, 2021. It is now read-only.
To fix Use adonis-websocket-client with Web Worker #74#75
Open
zhurlik wants to merge 2 commits intoadonisjs:developfrom
Open
To fix Use adonis-websocket-client with Web Worker #74#75zhurlik wants to merge 2 commits intoadonisjs:developfrom
zhurlik wants to merge 2 commits intoadonisjs:developfrom
Conversation
thetutlage
suggested changes
Jan 31, 2021
src/Connection/index.js
Outdated
|
|
||
| this.ws = new window.WebSocket(url) | ||
| // eslint-disable-next-line no-undef | ||
| this.ws = (typeof window !== 'undefined') ? new window.WebSocket(url) : new WebSocket(url) |
Member
There was a problem hiding this comment.
Can we move this check at the top level and then re-use it everywhere?
const hasWindow = typeof window !== 'undefined'
hasWindow ? new window.Websocket(url) : WebSocket(url)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#74