Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Fragment block #4

Closed
wants to merge 3 commits into from
Closed

Include Fragment block #4

wants to merge 3 commits into from

Conversation

ryanmparrish
Copy link
Contributor

@ryanmparrish ryanmparrish commented Apr 1, 2022

Adding the fragment block. Currently referenced(404) in the consonant/index page.
https://main--consonant--adobecom.hlx3.page/

RL for testing:

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #4 (28f3077) into main (ebbcb77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   52.93%   52.93%           
=======================================
  Files           2        2           
  Lines         546      546           
=======================================
  Hits          289      289           
  Misses        257      257           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0683714...28f3077. Read the comment docs.

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 1, 2022

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 1, 2022

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 1, 2022

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@ryanmparrish ryanmparrish requested review from auniverseaway and Sartxi and removed request for auniverseaway and seanchoi-dev April 1, 2022 18:23
@aem-code-sync
Copy link

aem-code-sync bot commented Apr 1, 2022

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Needs tests. Anything short of 100% is not approved.
  2. Should probably follow what was done in boilerplate.*
  • At this point at least. I think we need to change this to be a synthetic block that is URL based so we can put them inside blocks.

@rofe
Copy link

rofe commented Apr 4, 2022

On a related note, feel fere to inspire/copy from adobe/aem-boilerplate#66 (will likley not be added to the boilerplate)

@ryanmparrish
Copy link
Contributor Author

closing. Will be using the milo fragment implements

@ryanmparrish ryanmparrish deleted the fragment branch May 18, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants