Fixed an issue where an error while fetching schemas caused the XDM Object data element to be unusable #527
+1,734
−1,148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject data element to be unusable
carterworks
reviewed
Sep 16, 2025
| initialValues.schema = schemasFirstPage[0]; | ||
| } | ||
| } catch { | ||
| context.schemasFirstPage = []; |
Collaborator
There was a problem hiding this comment.
In both catch statements, I would feel more comfortable if we had some kind of logging or alert, just in case some issue pops up. Let me know what you think.
dompuiu
approved these changes
Oct 1, 2025
Collaborator
|
Updates from my commit:
|
…ion has a schema/sandbox but cannot load it
jonsnyder
commented
Jan 21, 2026
Collaborator
Author
jonsnyder
left a comment
jonsnyder
left a comment
There was a problem hiding this comment.
Amazing! I love the detailed tests.
| if (e.name === "AbortError") { | ||
| throw e; | ||
| } | ||
| throw e; |
Collaborator
Author
There was a problem hiding this comment.
It seems this catch block could be removed as it always throws.
carterworks
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Spencer: Alert and placeholder text for when unable to retrieve the sandbox/schema from a saved configuration
Types of changes
Checklist: