Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-21706 Cleanup fastly smartcrop code from core-components repo #2781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohiaror
Copy link
Contributor

@mohiaror mohiaror commented Jun 9, 2024

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Copy link

sonarcloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (6bdf5d0) to head (42f44fb).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2781      +/-   ##
============================================
- Coverage     87.17%   87.17%   -0.01%     
+ Complexity     2683     2676       -7     
============================================
  Files           235      233       -2     
  Lines          7166     7141      -25     
  Branches       1094     1092       -2     
============================================
- Hits           6247     6225      -22     
+ Misses          363      362       -1     
+ Partials        556      554       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohiaror
Copy link
Contributor Author

mohiaror commented Jun 9, 2024

We recently introduced support for sensei based smartcrop in core components and we no longer support fastly based smartcrop which was introduced last year. This PR intends to cleanup the code for fastly based smartcrop.

@vladbailescu , @LSantha Please note removal of an exported API package in this PR. I am not sure if it is recommended to remove the API or not. Considering that the API package only contained 1 class and that too should ideally not be of any use to customers, I think it is safe to delete it altogether. If you feel and advice otherwise then I can follow the conventional method of deprecating the API and throwing the exception from the implementation.

@HitmanInWis
Copy link

do we need to remove the following from the image component's _cq_editConfig.xml?

    <cq:actionConfigs jcr:primaryType="nt:unstructured">
        <ngdm-smartcrop
            jcr:primaryType="nt:unstructured"
            condition="CQ.AEMGo.image.actions.smartCrop.condition"
            handler="CQ.AEMGo.image.actions.smartCrop"
            icon="cropLightning"
            order="before CONFIGURE"
            text="Smart Crop"/>
    </cq:actionConfigs>

@HitmanInWis
Copy link

do we need to remove the following from the image component's _cq_editConfig.xml?

    <cq:actionConfigs jcr:primaryType="nt:unstructured">
        <ngdm-smartcrop
            jcr:primaryType="nt:unstructured"
            condition="CQ.AEMGo.image.actions.smartCrop.condition"
            handler="CQ.AEMGo.image.actions.smartCrop"
            icon="cropLightning"
            order="before CONFIGURE"
            text="Smart Crop"/>
    </cq:actionConfigs>

nevermind - was looking at an older version of WCM Core, I see this was already removed in eedb92c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants