-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change collectbase to /.rum/ #443
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with the change but aem.js is coming from https://github.com/adobe/aem-lib which brings along the sampleRUM
function from https://github.com/adobe/helix-rum-js. This is where the change needs to happen!
I can change it over there as well, but again, I don't have push perms on that repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's wrong, but @kptdobe's suggestion is also wrong, as aem.js
gets the update pushed from helix-rum-js
. We need to figure out if we can set sampleRUM.collectBaseURL
from the outside, and if not add a new variable like window.RUM_COLLECT
in helix-rum-js
and set it here in the boilerplate.
I'm not sure how these are pushed/merged as they are not identical right now ( |
|
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
This change merely adjusts the collectBaseURL to use the window.origin and thus not the rum.hlx.page domain.