Conversation
afranken
force-pushed
the
64-support-versioning
branch
2 times, most recently
from
35188ac to
4e4b8d4
Compare
afranken
force-pushed
the
64-support-versioning
branch
from
38a475e to
5790298
Compare
afranken
force-pushed
the
64-support-versioning
branch
from
c166973 to
e753b5f
Compare
afranken
force-pushed
the
64-support-versioning
branch
3 times, most recently
from
121b22d to
fb59d36
Compare
afranken
force-pushed
the
64-support-versioning
branch
3 times, most recently
from
121f4bb to
0562641
Compare
afranken
force-pushed
the
64-support-versioning
branch
3 times, most recently
from
cdd5511 to
eb29318
Compare
afranken
force-pushed
the
64-support-versioning
branch
2 times, most recently
from
c87be20 to
41d3fc3
Compare
afranken
force-pushed
the
64-support-versioning
branch
from
41d3fc3 to
8f372f6
Compare
This is a step to storing versions, as ACLs are stored by version in S3.
Needs extensive testing, delete marker implementation. Fixes #64
Not all aspects have been tested yet. Fixes #64
AWS has deprecated SDK for Java v1, and will remove support EOY 2025. S3Mock will remove usage of Java v1 early 2026.
Tested the ITs against S3, found a few unexpected behaviours, fixed S3Mock to reflect actual S3 behaviour. Fixes #64
afranken
force-pushed
the
64-support-versioning
branch
from
8f372f6 to
f5324b0
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 67 out of 70 changed files in this pull request and generated no comments.
Files not reviewed (3)
- build-config/src/main/resources/build-config/checkstyle.xml: Language not supported
- integration-tests/pom.xml: Language not supported
- server/pom.xml: Language not supported
Comments suppressed due to low confidence (2)
server/src/main/java/com/adobe/testing/s3mock/BucketController.java:517
- The removal of the 'startAfter' and 'continuationToken' request parameters in the listObjectVersions endpoint may impact pagination support. Please confirm that the updated signature and corresponding call to bucketService.listVersions is intentional and that any associated pagination behavior is handled appropriately.
public ResponseEntity<ListVersionsResult> listObjectVersions(
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/ListObjectVersionsV2IT.kt:65
- [nitpick] The test asserts that the versionId is exactly the literal 'null' for non-version enabled buckets. Consider checking for a null or absent value instead of the literal string 'null' to make the test more robust if the API behavior changes.
.containsExactlyInAnyOrder(Tuple(version1, true), Tuple(version2, true))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support versions in all APIs
Related Issue
Fixes #64
Tasks