Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use additional headers in the signature payload: #644

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use additional headers in the signature payload: #644

wants to merge 5 commits into from

Commits on Jun 9, 2023

  1. Use additional headers in the signature payload: 

    This will allow users to use headers in the signature
payload during the verification process. For example,
a timestamp header can be used to validate if requests
have been sent recently and reduce the risk of message
replays.

Signed-off-by: Jacob Weinstock <[email protected]>
    @jacobweinstock
    jacobweinstock committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    021efc3 View commit details
    Browse the repository at this point in the history

  2. Add code comment for signaturePayload 

    Signed-off-by: Jacob Weinstock <[email protected]>
    @jacobweinstock
    jacobweinstock committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    bd28fd0 View commit details
    Browse the repository at this point in the history

  3. Remove redundant length check: 

    The range body will not execute if the len
of r.Parameter.SignaturePayloadHeaders is 0.

Signed-off-by: Jacob Weinstock <[email protected]>
    @jacobweinstock
    jacobweinstock committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    753d12e View commit details
    Browse the repository at this point in the history

  4. Add tests for additional headers in sign payload: 

    Cover the Evaluate func with additional headers
for sha1, sha256, sha512.

Signed-off-by: Jacob Weinstock <[email protected]>
    @jacobweinstock
    jacobweinstock committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    665f955 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Update go.mod and github action: 

    Dependencies were old.

Signed-off-by: Jacob Weinstock <[email protected]>
    @jacobweinstock
    jacobweinstock committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    ac897f5 View commit details
    Browse the repository at this point in the history