Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recording the output of rosrust based nodes using rosbag, the connection header inside the rosbag file contains an empty
latching=
field, because this field is missing from the original connection header sent by rosrust's publisher.While upstream rosbag supports parsing this (and interprets it the same as
latching=0
),rosbag-rs issues:
Code to reproduce the behavior:
Without the patch, the bagfiles end up with an empty
latching=
header. With the patch, it's eitherlatching=0
orlatching=1
, depending on whether the publisher was latched or not.