Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to electron-forge 7.3.0 #73

Closed
wants to merge 22 commits into from
Closed

Conversation

adidahiya
Copy link
Owner

@adidahiya adidahiya commented Feb 25, 2024

Changes in this PR:

  • Upgrade to Electron v29.1
  • Upgrade to electron-forge v7.3.x, which includes a few implicit breaking changes to module resolution & loading
  • Upgrade to latest Vite v5.x
  • Add "type": "module" to raga-app package.json
  • Update electron-forge vite configs to use the suggested templates (adapted)
  • Modify preload script to avoid using any Node.js APIs
  • Modify raga-lib to use my fork of fluent-ffmpeg where I've converted the library from CommonJS to ES modules. This makes it easier for Electron Forge to load this dependency in the main/server entry points.

CI infra changes in this PR:

  • Migrate from standard Ubuntu Linux environment to macOS execution environment
  • Update Deno install path accordingly for macOS

Not done in this PR:

References:

@adidahiya adidahiya changed the title WIP upgrade to electron-forge 7.3.0 Upgrade to electron-forge 7.3.0 Mar 13, 2024
@adidahiya adidahiya marked this pull request as ready for review March 13, 2024 17:14
@adidahiya
Copy link
Owner Author

Things are working in dev mode now, but this seems to have broken the ffmpeg path in the production dist build (#67, 7b187d6).

Not sure if it's worth continuing to debug further at this point, spent nearly a whole day on it.

@adidahiya
Copy link
Owner Author

fixed by #245

@adidahiya adidahiya closed this Oct 10, 2024
@adidahiya adidahiya deleted the ad/electron-forge-upgrade branch October 10, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant