Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review page to navigator #83

Merged
merged 7 commits into from
Dec 11, 2020
Merged

Conversation

jasalisbury
Copy link

Description of change
The review page is the last page of the navigator. It does not use the navigator form component like the other pages of the form. It only shows nav state when the form as been submitted.

How to test

  1. Pull down changes
  2. Go to the review section of the activity reports, the submit button is disabled
  3. Completely fill out the form, clicking "continue" on every page
  4. The submit button is no longer disabled
  5. Click submit, note the state of the review page in the "side nav"
  6. Go to the first page and unselect all grantees
  7. The submit button is disabled

Note
This PR adds the mechanism for adding a review page. The current review page is a placeholder. There will be an additional PR with the review page as designed later. Let me know if you want me to keep splitting up PRs like this!

Issue(s)

Checklist

  • [n/a] Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] Documentation updated

The review page is the last page of the navigator. It does not use the
navigator form component like the other pages of the form. It Only shows
nav state when the form as been submitted.
Copy link
Collaborator

@kryswisnaskas kryswisnaskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Works as advertised, but I noticed one inconsistency - not sure if that is not supposed to work yet.
When going back and removing all grantees, the "Submit" button becomes disabled but, the side nav "Submitted" button stays.

other minor observation - there seemed to be too little space between text and the "Submit" button
image

@kryswisnaskas
Copy link
Collaborator

Let me know if you want me to keep splitting up PRs like this!

If it works for you, I am perfectly fine with this approach. Smaller PRs are usually easier for the reviewers 👍

@jasalisbury
Copy link
Author

When going back and removing all grantees, the "Submit" button becomes disabled but, the side nav "Submitted" button stays.

Yeah that isn't explicitly handled yet as I'm not sure how we should handle it.

other minor observation - there seemed to be too little space between text and the "Submit" button

Yeah it is missing a space, I'll update.

@jasalisbury jasalisbury merged commit 131e612 into main Dec 11, 2020
@jasalisbury jasalisbury deleted the js-135-add-review-page-to-navigator branch December 11, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants