-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add review page to navigator #83
Conversation
The review page is the last page of the navigator. It does not use the navigator form component like the other pages of the form. It Only shows nav state when the form as been submitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Works as advertised, but I noticed one inconsistency - not sure if that is not supposed to work yet.
When going back and removing all grantees, the "Submit" button becomes disabled but, the side nav "Submitted" button stays.
other minor observation - there seemed to be too little space between text and the "Submit" button
If it works for you, I am perfectly fine with this approach. Smaller PRs are usually easier for the reviewers 👍 |
Yeah that isn't explicitly handled yet as I'm not sure how we should handle it.
Yeah it is missing a space, I'll update. |
Description of change
The review page is the last page of the navigator. It does not use the navigator form component like the other pages of the form. It only shows nav state when the form as been submitted.
How to test
Note
This PR adds the mechanism for adding a review page. The current review page is a placeholder. There will be an additional PR with the review page as designed later. Let me know if you want me to keep splitting up PRs like this!
Issue(s)
Checklist