Saving an activity report feedback #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `--runInBand`, it appears to no longer be needed to prevent a race with tests that hit the database
rahearn
suggested changes
Jan 19, 2021
There was a problem hiding this comment.
This is a lot cleaner, thanks.
Before merging, the newly renamed activity-recipients.yaml doc still references the old participant schema. Also, would it be possible to add a quick descriptive sentence at least to each overall object in the API docs, if not each field as well, especially any that aren't obvious.
| @@ -18,7 +18,7 @@ | |||
| "server:debug": "nodemon src/index.js --exec babel-node --inspect", | |||
| "client": "yarn --cwd frontend start", | |||
| "test": "jest src", | |||
| "test:ci": "cross-env JEST_JUNIT_OUTPUT_DIR=reports JEST_JUNIT_OUTPUT_NAME=unit.xml POSTGRES_USERNAME=postgres POSTGRES_DB=ttasmarthub CURRENT_USER_ID=5 CI=true jest src tools --runInBand --coverage --reporters=default --reporters=jest-junit", | |||
| "test:ci": "cross-env JEST_JUNIT_OUTPUT_DIR=reports JEST_JUNIT_OUTPUT_NAME=unit.xml POSTGRES_USERNAME=postgres POSTGRES_DB=ttasmarthub CURRENT_USER_ID=5 CI=true jest src tools --coverage --reporters=default --reporters=jest-junit", | |||
Found a test that was removing all request errors, which was causing failures when tests were run in parrallel. Was able to update the test enabling parallel test runs
|
It looks like the |
Oh forgot to update that whole file! Should be updated now. I had to hard refresh locally to get redoc to show the new changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
--runInBand, it appears to no longer be needed to prevent a race with tests that hit the databaseHow to test
Pull down, run all tests
Issue(s)