review page feedback #107
Merged
review page feedback #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The url resource now shows up in activity reports review page * Add openapi route for the `approvers` endpoint. Held off on adding a route for submit until it is fully implemented * Removed old fake data from the review page (additional notes and approving managers are now blank) * Removed dumbeldore as an approver as he has no "name". Added another approver to the fake data
jasalisbury
commented
Jan 5, 2021
| schema: | ||
| type: array | ||
| items: | ||
| $ref: '../../index.yaml#/components/schemas/approvingUser' |
There was a problem hiding this comment.
I'd like for a better solution for these relative links, seems like they could potentially get pretty unwieldy
rahearn
reviewed
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
approversendpoint. Held off on adding a route for submit until it is fully implementedapprover to the fake data
How to test
approversfield for appropriate dataResources usedfield intopics and resourcesand make sure it shows up on the review pagelocalhost:5000Issue(s)
Checklist