Mount the workspace and set as default workdir#24
Open
ldaneliukas wants to merge 4 commits intoaddnab:mainfrom
Open
Mount the workspace and set as default workdir#24ldaneliukas wants to merge 4 commits intoaddnab:mainfrom
ldaneliukas wants to merge 4 commits intoaddnab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #23 , when running containers directly, they will automatically mount the Github workspace and set it as the
workdirfor the container, so that all of the repository contents could be accessed (assuming a checkout was done).This seems like a safe default and it'd be intuitive to keep this flow when running containers via the
docker-run-action.Changes:
workdirfor the container. Defaults to $GITHUB_WORKSPACENote, this change depends on #23 , since the container we are running needs to know about the Github environment variables in order to mount the correct volume for the workspace. As the action is now, we are ignoring all Github and user-defined env vars (set via
env:on the step).