-
-
Notifications
You must be signed in to change notification settings - Fork 334
fix: table handling and img tags inside tables #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fix: add recall settings for paragraph with text
|
Hi @masumsoft, could you please make sure that the tests pass? |
|
@adbar I've fixed the root cause and all tests are passing now. As we are allowing blank columns to remain as is to keep table structure consistent, as a side effect blank link elements inside tables were also passed as table column. The root cause was that the table link density test was not removing blank links, hence failing the test. I've now fixed the table link density test to not blindly allow blank elements. |
|
Hi @masumsoft, thanks, could you please fix the mypy error in Python 3.13? |
|
Hi @adbar, I've fixed the mypy error in python 3.13 for incompatible type argument. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #803 +/- ##
==========================================
- Coverage 99.29% 99.07% -0.22%
==========================================
Files 21 21
Lines 3664 3676 +12
==========================================
+ Hits 3638 3642 +4
- Misses 26 34 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @masumsoft, please make sure your changes are covered in the unit tests. |
|
I want to know when this issue can be fixed? really appreciate it. |
fix: handle nested tables inside list component
favor_recallis set to True.fix: convert graphic, row and cell to html
included_imagesfailed when trying to extract images in a table #396 as a side effect